Check that kernel source code has extern C defined #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariodruiz
added a commit
to mariodruiz/Riallto
that referenced
this pull request
Oct 15, 2024
* Verify that kernel code is wrapped in extern C * Remove curly braces * Add breakline * Change raise type * Fix checks * Return RunTime error * Check construct * Use Syntax error * Change way we do pytest * Only check if extern C exists * Remove unused check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem solved by the commit
No check is done about kernel wrapping top function in extern C, this leads to application not being built with a not very useful error message. #65
How is the problem solved?
Add two simple checks to see if the extern C string is in the source file
Are there any risks associated to the change?
No
Is there a documentation impact?
No
Checklist
Please provide screenshots (if applicable)
Related issues